Build testpackage definition automatically from directories. #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every test should now have a test_spec.sh shell fragment that adds to the corresponding shell arrays (the preexisting ones have been added appropriately)
ykempf
approved these changes
Jun 8, 2023
| single_cell[1]=1 | ||
| # If no tests are specified, run all tests/ subdirectories. | ||
| if [ "${#tests[@]}" -eq "0" ]; then | ||
| tests=($(ls -d tests/*)) |
There was a problem hiding this comment.
Use /usr/bin/ls to avoid messups with default --color.
|
Right so restart write should come before read unlike the alphabet, so these will need to either be redesigned to be one test in one go, or sequential. |
|
Hmm. It would perhaps make sense to place the actual launch commands for each test in a file inside that directory. Then each launch file could include several launch commands, and eg. the read-write-test could be a single one. If we want to compare different rank/thread combos, then we could also trigger those from those files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every test should now have a test_spec.sh shell fragment that adds to the corresponding shell arrays (the preexisting ones have been added appropriately).
Small_test_definitions.sh then, instead of having the hardcoded list of tests, iterates through all tests/ directories and builds the array from those.
Alternatively, the user can still supply a list of test names to run in the small_test_definitinos.sh tests array.